This group is archived! You have permission to view it!

Scheduling - SDAMA307

The routine SDAMA307 is using a Cache specific $Q function.

SDAMA307.m
.SDREF=$Q(@SDREF,SDDIR)
                        ^-----
At column 20, line 161, source module /srv/vista/dewdrop/routines/SDAMA307.m
%GTM-E-RPARENMISSING, Right parenthesis expected

http://code.osehra.org/dox/Routine_SDAMA307.html

I wasn't sure whether to put this in refactoring services since its scheduling related.

On a side note...

  1. I was attempting to examine whether or not the routine was actually used vs called. Called has been well defined in the routine link above - caller and call graphs. For the sake of this discussion used defines something that explicitly causes/triggers the pieces of code to be executed. An example of use - could be a menu that a user invokes through the terminal. Wouldn't it make sense to also graph which menu options can cause portions of the routine to execute code? You could continue to extend the idea further by graphing HL7 events as well.
  2. I'm asking because as the codebase is refactored I don't understand how we assess whether or not the code in XYZ routine is still used and/or deprecated. Or maybe we're taking a different approach? 

Comments

jason.li

Scheduling - SDAMA307

Hi Chris, Those are excellent suggestions on how to improve the current Visual Cross-Reference Documentation. Thanks for pointing them out. Right now, we already had an OSEHRA JIRA ticket http://issues.osehra.org/browse/CGCT-4 to extract the RPC call dependencies based on OPTION file(#19) and REMOTE PROCEDURE file(#8994), I will create two more tickets for extracting routine dependencies based on OPTION file and HL7. I am currently swamped with some other tasks, and may not be able to get to this in a timely manner. If someone is interested in these tasks and has a good understanding of Python, I will be happy to help out. Again, the code to generate the documentation is under https://github.com/OSEHRA/VistA/tree/803f8b16/Utilities/Dox/PythonScripts and the documentation is under: http://www.osehra.org/document/instructions-generate-visual-cross-refere... Thanks, - Jason On Mon, Oct 29, 2012 at 2:52 PM, chris.uyehara wrote: > The routine SDAMA307 is using a Cache specific $Q function. > > SDAMA307.m > .SDREF=$Q(@SDREF,SDDIR) > ^----- > At column 20, line 161, source module > /srv/vista/dewdrop/routines/SDAMA307.m > %GTM-E-RPARENMISSING, Right parenthesis expected > > http://code.osehra.org/dox/Routine_SDAMA307.html > > I wasn't sure whether to put this in refactoring services since its > scheduling related. > > On a side note... > > 1. I was attempting to examine whether or not the routine was actually > used vs called. Called has been well defined in the routine link above - > caller and call graphs. For the sake of this discussion used defines > something that explicitly causes/triggers the pieces of code to be > executed. An example of use - could be a menu that a user invokes through > the terminal. Wouldn't it make sense to also graph which menu options can > cause portions of the routine to execute code? You could continue to extend > the idea further by graphing HL7 events as well. > 2. I'm asking because as the codebase is refactored I don't understand > how we assess whether or not the code in XYZ routine is still used and/or > deprecated. Or maybe we're taking a different approach? > > -- > Full post: http://www.osehra.org/discussion/scheduling-sdama307 > Manage my subscriptions: > http://www.osehra.org/og_mailinglist/subscriptions > Stop emails for this post: > http://www.osehra.org/og_mailinglist/unsubscribe/1116 > -- Jason Li Kitware, Inc. R&D Engineer 28 Corporate Dr Clifton Park, NY 12065

shabiel

Scheduling - SDAMA307

Just in case this helps, I think this routine is called from CPRS at
the cover sheet and maybe also from the Reminders package.

Sam

On Mon, Oct 29, 2012 at 11:52 AM, chris.uyehara wrote:
> The routine SDAMA307 is using a Cache specific $Q function.
>
> SDAMA307.m
> .SDREF=$Q(@SDREF,SDDIR)
> ^-----
> At column 20, line 161, source module /srv/vista/dewdrop/routines/SDAMA307.m
> %GTM-E-RPARENMISSING, Right parenthesis expected
>
> http://code.osehra.org/dox/Routine_SDAMA307.html
>
> I wasn't sure whether to put this in refactoring services since its
> scheduling related.
>
> On a side note...
>
> I was attempting to examine whether or not the routine was actually used vs
> called. Called has been well defined in the routine link above - caller and
> call graphs. For the sake of this discussion used defines something that
> explicitly causes/triggers the pieces of code to be executed. An example of
> use - could be a menu that a user invokes through the terminal. Wouldn't it
> make sense to also graph which menu options can cause portions of the
> routine to execute code? You could continue to extend the idea further by
> graphing HL7 events as well.
> I'm asking because as the codebase is refactored I don't understand how we
> assess whether or not the code in XYZ routine is still used and/or
> deprecated. Or maybe we're taking a different approach?
>
> --
> Full post: http://www.osehra.org/discussion/scheduling-sdama307
> Manage my subscriptions: http://www.osehra.org/og_mailinglist/subscriptions
> Stop emails for this post:
> http://www.osehra.org/og_mailinglist/unsubscribe/1116

chris.uyehara

domo arigato

domo arigato