Gerrit Final Review

Gerrit Final Review

 

A final review is a necessary confirmation that all required procedures have been executed, the submission is complete, and that the code is ready to be included into the OSEHRA code base.  Only one passing final review is required for a submission and the code contribution can be merged into the OSEHRA code base as soon as a passing final review has been attested.  As such, final reviews can only be made by a trusted individual who possesses sufficient permission to perform the code merge step.

Gerrit peer review is based on the “OSEHRA Final Review Checklist”.  This should be downloaded from the OSEHRA web site, http://www.osehra.org, prior to beginning the review process.

To perform a final review, go to the OSERHA Gerrit review site at http://review.code.osehra.org and log in.  Find the article you want to review.  Click on the article to bring up the publication page, and then click the one of the diff buttons (blue arrows) to bring up a code review tool (Figure 3).  Verify that the code seems to fix the corresponding Jira issue and that the code appears to be compliant with the OSEHRA SAC.  Walk through the “OSEHRA Final Review Checklist” executing all the appropriate tests for Safe, Compliant, and Functional and marking all items Pass or Fail. Once the status of the code with respect to the checklist has been determined, press the review button to bring up the attestation page (Figure 4).  For each of Safe, Compliant, and Functional; mark the section +1 if all the items in the checklist have a pass for the section.  If all three sections have a pass and the visual code review looked good, mark the Code Review Attestation +1 (+2 if you are a trusted reviewer).  Press Publish Comments to end the review and submit the results to the OSEHRA Dashboard. Note that any sections marked -1 when the “Submit Review” button is clicked will show up as a failing test on the dashboard.  Complete the review by uploading the completed checklist document to the Jira issue tracker, attaching it to the corresponding Jira issue, and then merge the change into the OSEHRA code base using the Gerrit merge procedures.

 

Figure 3- Gerrit Code Review Site with Review Button (red arrow) and Diff Buttons (blue arrows).

 

Figure 4- Code review attestations.

 

Return to Previous Page

Return to the Main Page

like0

Contributors